Adding Unit Test for Description Component #480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anubh-v
reviewed
Nov 14, 2020
tests/app/shared/issue/description/description.component.spec.ts
Outdated
Show resolved
Hide resolved
tests/app/shared/issue/description/description.component.spec.ts
Outdated
Show resolved
Hide resolved
tests/app/shared/issue/description/description.component.spec.ts
Outdated
Show resolved
Hide resolved
tests/app/shared/issue/description/description.component.spec.ts
Outdated
Show resolved
Hide resolved
tests/app/shared/issue/description/description.component.spec.ts
Outdated
Show resolved
Hide resolved
tests/app/shared/issue/description/description.component.spec.ts
Outdated
Show resolved
Hide resolved
anubh-v
reviewed
Nov 14, 2020
tests/app/shared/issue/description/description.component.spec.ts
Outdated
Show resolved
Hide resolved
|
okay! Psps i clicked on the wrong button |
|
@seanlowjk could you re-trigger the Travis build (perhaps with an empty commit) ? |
|
Not too sure why the Travis build is failing, since it passed previously and the most recent change is trivial. |
|
okay sure, I think there is some problem with the Mac build in Travis. |
|
I have tried building the Mac version. It works. Either Travis is having some issue or it may be using the new Big Sur MacOS, causing the build to fail. |
anubh-v
added a commit
to anubh-v/CATcher
that referenced
this pull request
Dec 17, 2020
* Add IsCategorical Tests * Add automated build for Linux and MacOS (CATcher-org#479) * Add Conflict Model Tests (CATcher-org#487) * Update usage instructions for Windows (CATcher-org#488) * Prevent unwanted caching by adding headers to API calls (CATcher-org#482) * Relax template correctness rule (CATcher-org#484) * Create logging (CATcher-org#481) * Update package.json * Direct import logger into main electron process (CATcher-org#489) * Update usage-notes.md * Update usage-notes.md * Update usage-notes.md * Fix Regex Checker and Tests * Fix for Copy Pasting of MacOS (CATcher-org#496) Edit Control Key Directives to include Mac * Fix Alt Tabbing Bug (CATcher-org#497) * Version Bump * Refactor Label Model * Adding Unit Test for Description Component (CATcher-org#480) * Adding Tests for Instance Methods for Issue Model (CATcher-org#495) Add Tests to the following methods: clone(), numOfUnresolvedDisputes(), createGithubTesterResponse(), createGithubTutorResponse(), createGithubTeamResponse(), createGithubIssueDescription() * Fix Pasting of images (CATcher-org#505) Used browser based paste event * CATcher version bump * Migrate CI to Github Actions from Appveyor and Travis (CATcher-org#509) - Migrate CI to Github Actions - Remove dependency on csv-parse * Update README.md * Fix Tests Names and Tests Grouping * Make Labelling Adjectives Clearer * Fix Typos Co-authored-by: Low Jun Kai, Sean <[email protected]> Co-authored-by: Low Jun Kai, Sean <[email protected]> Co-authored-by: Koh Jun Wei <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fixes #468
Description
To be updated.