-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add profiles component tests #971
Add profiles component tests #971
Conversation
Codecov ReportBase: 58.49% // Head: 58.03% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #971 +/- ##
==========================================
- Coverage 58.49% 58.03% -0.46%
==========================================
Files 98 100 +2
Lines 2248 2295 +47
Branches 255 260 +5
==========================================
+ Hits 1315 1332 +17
- Misses 889 917 +28
- Partials 44 46 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Need reviews from developers more familiar with tests @CATcher-org/developers |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM other than a small nitpick! 👍
}); | ||
}); | ||
|
||
it('should emit the correct profile when mat-option is clicked', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it might be clearer if we specify the name of the function selectProfile
that is triggered when mat-option is clicked
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed the spec description to should emit the correct profile through selectProfile when mat-option is clicked
. Hope that is satisfactory!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Summary:
Fixes #601
Changes Made:
src/test.ts
which is required to enable some test utilities (e.g. fakeAsync)To test that the selected profile and repo name is correctly displayed, we can look into writing component tests for the
sessionSelectionComponent
.Proposed Commit Message: