Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add profiles component tests #971

Merged
merged 6 commits into from
Nov 13, 2022
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/test.ts
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
// This file is required by karma.conf.js and loads recursively all the .spec and framework files
import 'zone.js/dist/zone-testing'; // This import must be at the top

import { getTestBed } from '@angular/core/testing';
import { BrowserDynamicTestingModule, platformBrowserDynamicTesting } from '@angular/platform-browser-dynamic/testing';
import 'zone.js/dist/zone-testing';

declare const require: any;

Expand Down
106 changes: 106 additions & 0 deletions tests/app/auth/profiles/profiles.component.spec.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,106 @@
import { Component, DebugElement } from '@angular/core';
import { async, ComponentFixture, fakeAsync, TestBed, tick } from '@angular/core/testing';
import { BrowserAnimationsModule } from '@angular/platform-browser/animations';

import { ProfilesComponent } from '../../../../src/app/auth/profiles/profiles.component';
import { Profile } from '../../../../src/app/core/models/profile.model';
import { ErrorHandlingService } from '../../../../src/app/core/services/error-handling.service';
import { ProfileService } from '../../../../src/app/core/services/profile.service';
import { SharedModule } from '../../../../src/app/shared/shared.module';

@Component({
template: `<app-profiles (selectedProfileEmitter)="onSelected($event)"> </app-profiles>`
})
class TestHostComponent {
selectedProfile: Profile | undefined;
onSelected(profile: Profile) {
this.selectedProfile = profile;
}
}

describe('ProfilesComponent', () => {
let fixture: ComponentFixture<TestHostComponent>;
let debugElement: DebugElement;
let nativeElement: HTMLElement;
let testHost: TestHostComponent;
let profilesEl: HTMLElement;

const profileService = jasmine.createSpyObj('ProfileService', ['fetchExternalProfiles']);
const errorHandlingService = jasmine.createSpyObj('ErrorHandlingService', ['handleError']);

const testProfiles: Profile[] = [
{
profileName: 'testProfile1',
repoName: 'test-org1/pe'
},
{
profileName: 'testProfile2',
repoName: 'test-org2/pe'
},
{
profileName: 'testProfile3',
repoName: 'test-org3/pe'
}
];

beforeEach(async(() => {
TestBed.configureTestingModule({
imports: [BrowserAnimationsModule, SharedModule],
declarations: [ProfilesComponent, TestHostComponent],
providers: [
{ provide: ProfileService, useValue: profileService },
{ provide: ErrorHandlingService, useValue: errorHandlingService }
]
}).compileComponents();
}));

beforeEach(fakeAsync(() => {
profileService.fetchExternalProfiles.and.returnValue(Promise.resolve(testProfiles));

fixture = TestBed.createComponent(TestHostComponent);
testHost = fixture.componentInstance;

debugElement = fixture.debugElement;
nativeElement = debugElement.nativeElement;
profilesEl = <HTMLElement>nativeElement.querySelector('app-profiles');

fixture.detectChanges(); // onInit()
tick(); // wait for profiles to be loaded
}));

it('should display the correct profiles from AppConfig', () => {
openMatSelect();
const displayedOptions = getOptions();

displayedOptions.slice(1).forEach((el, i) => {
const optionTextEl = <HTMLElement>el.querySelector('.mat-option-text');
if (!optionTextEl) {
fail('optionTextEl should not be null');
}
const profileName = optionTextEl.innerText;
expect(profileName).toBe(testProfiles[i].profileName);
});
});

it('should emit the correct profile when mat-option is clicked', () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it might be clearer if we specify the name of the function selectProfile that is triggered when mat-option is clicked

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed the spec description to should emit the correct profile through selectProfile when mat-option is clicked. Hope that is satisfactory!

openMatSelect();
const displayedOptions = getOptions();

displayedOptions[3].click();
expect(testHost.selectedProfile).toEqual(testProfiles[2]);
fixture.detectChanges();
});

function openMatSelect(): void {
const select = <HTMLElement>profilesEl.querySelector('.mat-select');
if (!select) {
fail('Select should not be null');
}
select.click();
fixture.detectChanges();
}

function getOptions(): HTMLElement[] {
return Array.from(document.querySelectorAll('.mat-option'));
}
});