Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create Docker containers and remove envmodules #102

Merged
merged 112 commits into from
Sep 12, 2024
Merged

create Docker containers and remove envmodules #102

merged 112 commits into from
Sep 12, 2024

Conversation

kelly-sovacool
Copy link
Member

@kelly-sovacool kelly-sovacool commented Mar 28, 2024

Changes

  • Set container URLs in config file
  • Specify containers for all rules instead of envmodules
  • Create containers as needed in docker/, with github actions to update them

Issues

Checklist

  • update changelog

@kelly-sovacool
Copy link
Member Author

kelly-sovacool commented May 21, 2024

  • also need to copy resources from zeigelbauer dir to shared pipeliner dir /data/CCBR_Pipeliner/db/PipeDB/charlie/fastas_gtfs

@kelly-sovacool kelly-sovacool marked this pull request as ready for review May 21, 2024 17:52
@kelly-sovacool
Copy link
Member Author

test runs completed succesfully on biowulf and FRCE. @kopardev this is ready for your review.

Copy link
Member

@kopardev kopardev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deserves minor release increment.

@kelly-sovacool kelly-sovacool merged commit 928e8a5 into main Sep 12, 2024
1 check passed
@kelly-sovacool kelly-sovacool deleted the iss-99 branch September 12, 2024 21:07
@kelly-sovacool
Copy link
Member Author

kelly-sovacool commented Sep 12, 2024

deserves minor release increment.

@kopardev
previously (#107 & #110) we had planned on the next version being v1.0.0 after this PR -- do you think it should be v0.11.0 instead? I think that's fine since we may want to reserve v1.0.0 for a more major change to the CLI in the future.

@kelly-sovacool kelly-sovacool added this to the 2024-06 milestone Sep 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants