Add dump_last feature to icepack. #220
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apcraig
requested changes
Sep 11, 2018
There was a problem hiding this comment.
This PR has the CMIP changes in it. I think it should be closed until the CMIP changes are merged and the branch has been updated to the Consortium master. If the CMIP branch has further changes, the CMIP branch and this branch are going to get convoluted and we may lose some of the mods.
Also, I don't think set_nml.smoke is going to be picked up by the smoke test. There need to be some changes in icepack.setup to make that happen. At least that was my experience, but maybe I'm wrong. Have you confirmed that with these changes, the smoke test generates a restart at the end of the run?
|
I misunderstood the earlier conversation. I will close it for now. |
lettie-roach
pushed a commit
to lettie-roach/Icepack
that referenced
this pull request
Oct 18, 2022
…ortium#220) * Added k1 basal stress parameter in namelist, added scripts for Philippe's machine * Updated documentation for landfast parameterization
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the functionality to icepack to write a restart on the last step of a run. By default it is off. It will be turned on for smoke tests. Note, this is on top of the CMIP.
Developer(s): D. Bailey
Please suggest code Pull Request reviewers in the column at right.
Are the code changes bit for bit, different at roundoff level, or more substantial? BFB
Is the documentation being updated with this PR? (Y/N) N
If not, does the documentation need to be updated separately at a later time? (Y/N) Y
Note: "Documentation" includes information on the wiki and .rst files in doc/source/,
which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-icepack/.
Other Relevant Details: