Add dump_last namelist feature and turn it on for smoke tests. #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we wait for the CMIP PR to be closed before doing this one? I don't think there will be conflicts, but am also happy to wait. I guess we are waiting on one more review for the CMIP PR? |
|
I think this one can go in anytime. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add dump_last namelist feature and turn it on for smoke tests by default. Some bgc tests were not producing any restart files so no comparison or regression testing was working. See issue #220.
Developer(s): tcraig
Are the code changes bit for bit, different at roundoff level, or more substantial? bit-for-bit
Is the documentation being updated with this PR? (Y/N) Y
If not, does the documentation need to be updated separately at a later time? (Y/N)
Other Relevant Details:
Tested on conrad with intel, pgi, cray, and gnu with all bgc tests as well as the quick_suite, bit-for-bit. Verified restarts are created and regression testing works with smoke bgc tests.