Add docs on producing binaries with GA4GH support #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shukapoo
reviewed
Jul 29, 2020
nextflow_TES/README.md
Outdated
| @@ -10,7 +10,7 @@ Instructions below have been tested for CSC Rahti cloud running on RedHat OpenSh | |||
| # Cloud parameters | |||
| export CLOUD_BASE_URL=c03.k8s-popup.csc.fi:8443 | |||
| export CLOUD_NAMESPACE=tesk-cineca | |||
| export NEXTFLOW_POD=nextflow-dockerhub-7-9bdlm | |||
| export NEXTFLOW_POD=nextflow-dockerhub-10-gcdt8 | |||
There was a problem hiding this comment.
This pod name will keep changing whenever pod is rebuild by user or is involuntary build up by OpenShift cluster due to pod rescue, load balancing etc..Shall we mention it in readme so that reader doesn't get confused that it is related to hardcoded Nextflow container name/tags
There was a problem hiding this comment.
Good point. I reflected it here: 2369129
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated nextflow-io/nextflow#1666 as requested by the Nextflow maintainer, and now updating our internal docs for that accordingly.