Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Noref/bump linter #2765

Merged
merged 4 commits into from
Aug 15, 2024
Merged

Noref/bump linter #2765

merged 4 commits into from
Aug 15, 2024

Conversation

samoddball
Copy link
Contributor

NOREF

Description

How to test this change

  • download new linter
curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(go env GOPATH)/bin v1.60.1
  • run linter locally on this branch golangci-lint run or scripts/dev lint

PR Author Checklist

  • I have provided a detailed description of the changes in this PR.
  • I have provided clear instructions on how to test the changes in this PR.
  • I have updated tests or written new tests as appropriate in this PR.

PR Reviewer Guidelines

  • It's best to pull the branch locally and test it, rather than just looking at the code online!
  • When approving a PR, provide a reason why you're approving it
    • e.g. "Approving because I tested it locally and all functionality works as expected"
    • e.g. "Approving because the change is simple and matches the Figma design"
  • Don't be afraid to leave comments or ask questions, especially if you don't understand why something was done! (This is often a great time to suggest code comments or documentation updates)
  • Check that all code is adequately covered by tests - if it isn't feel free to suggest the addition of tests.

@samoddball samoddball requested a review from mynar7 August 15, 2024 18:14
@samoddball samoddball requested review from a team as code owners August 15, 2024 18:14
@samoddball samoddball requested review from adamodd and removed request for a team August 15, 2024 18:14
@samoddball samoddball merged commit 66ff087 into main Aug 15, 2024
12 checks passed
@samoddball samoddball deleted the NOREF/bump_linter branch August 15, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants