staticcheck: propagate Go version #4907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldez
force-pushed
the
fix/staticcheck-goversion
branch
2 times, most recently
from
55f5cf7
to
5699e94
Compare
ldez
force-pushed
the
fix/staticcheck-goversion
branch
2 times, most recently
from
cbd414a
to
82238d1
Compare
ldez
added
the
linter: update
ldez
force-pushed
the
fix/staticcheck-goversion
branch
from
82238d1
to
c122cb6
Compare
ldez
force-pushed
the
fix/staticcheck-goversion
branch
from
c122cb6
to
28fc300
Compare
bombsimon
approved these changes
Aug 14, 2024
3 tasks
7 tasks
7 tasks
uudashr
pushed a commit
to uudashr/golangci-lint
that referenced
this pull request
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4905
This is a kind of temporary workaround, I need to think more about another approach.
Related to dominikh/go-tools@bc9aaa8
Note: when using a previous Go version (ex: go1.22) with a binary built with go1.23, there is an explosion of the memory consumption that leads to a crash (no panic, just the process is terminated by the OS).
I need to investigate more, but for now, this workaround will disable the unexpected old rules (ex: SA3000, SA1003, etc.).