BCDA-5355: Disable ALR export endpoints #853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -54,7 +54,9 @@ func NewAPIRouter() http.Handler { | |||
|
|
|||
| r.Route("/api/v1", func(r chi.Router) { | |||
| r.With(append(commonAuth, requestValidators...)...).Get(m.WrapHandler("/Patient/$export", v1.BulkPatientRequest)) | |||
| r.With(append(commonAuth, requestValidators...)...).Get(m.WrapHandler("/alr/$export", v1.ALRRequest)) | |||
| if conf.GetEnv("ENABLE_ALR_ENDPOINTS") == "true" { | |||
There was a problem hiding this comment.
nice and simple! LGTM.
laurenkrugen-navapbc
approved these changes
Jun 23, 2023
laurenkrugen-navapbc
pushed a commit
that referenced
this pull request
Jul 11, 2023
## 🎫 Ticket https://jira.cms.gov/browse/BCDA-5355 ## 🛠 Changes - Disable ALR endpoints in deployed environments ## ℹ️ Context for reviewers The ALR export endpoints were never completed and officially released, and they should be disabled to prevent confusion. Since the default is false, I didn't add env vars for ENABLE_ALR_ENDPOINTS in our deployed environments. However, if folks feel we should have those, I can add that separately. ## ✅ Acceptance Validation Verified locally: ```sh bcda-app: curl -X GET 'http://localhost:3000/api/v2/alr/$export' \ -H "accept: application/fhir+json" \ -H "Prefer: respond-async" \ -H "Authorization: Bearer $token" 404 page not found bcda-app: curl -X GET 'http://localhost:3000/api/v1/alr/$export' \ -H "accept: application/fhir+json" \ -H "Prefer: respond-async" \ -H "Authorization: Bearer $token" 404 page not found ``` ## 🔒 Security Implications - [ ] This PR adds a new software dependency or dependencies. - [ ] This PR modifies or invalidates one or more of our security controls. - [ ] This PR stores or transmits data that was not stored or transmitted before. - [ ] This PR requires additional review of its security implications for other reasons.
kyeah
added a commit
that referenced
this pull request
Jul 2, 2024
## 🎫 Ticket https://jira.cms.gov/browse/BCDA-8227 ## 🛠 Changes - Replace completed_job_count with a count of unique job keys (based on job_key.que_job_id) - Avoid re-processing ALR job if que job was already processed ## ℹ️ Context As part of #964, I discovered that the completed_job_count was still being used as part of ALR jobs. This applies the same fix from the "normal" export jobs in #962. Note that many different job keys can be produced by an ALR job. To simplify the determination of whether a que job was processed, I added a new "getUniqueJobKeyCount" method. For some historical context, the ALR endpoints are not enabled in deployed environments - see #853 for more details. To avoid making a decision on whether to remove the code entirely, I am applying these changes for now to remove completed_job_count. ## 🧪 Validation Unit Testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
https://jira.cms.gov/browse/BCDA-5355
🛠 Changes
ℹ️ Context for reviewers
The ALR export endpoints were never completed and officially released, and they should be disabled to prevent confusion.
Since the default is false, I didn't add env vars for ENABLE_ALR_ENDPOINTS in our deployed environments. However, if folks feel we should have those, I can add that separately.
✅ Acceptance Validation
Verified locally:
🔒 Security Implications