BCDA-8215: Remove completed job count application logic #964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
kyeah
changed the title
kyeah
added a commit
that referenced
this pull request
Jul 2, 2024
## 🎫 Ticket https://jira.cms.gov/browse/BCDA-8227 ## 🛠 Changes - Replace completed_job_count with a count of unique job keys (based on job_key.que_job_id) - Avoid re-processing ALR job if que job was already processed ## ℹ️ Context As part of #964, I discovered that the completed_job_count was still being used as part of ALR jobs. This applies the same fix from the "normal" export jobs in #962. Note that many different job keys can be produced by an ALR job. To simplify the determination of whether a que job was processed, I added a new "getUniqueJobKeyCount" method. For some historical context, the ALR endpoints are not enabled in deployed environments - see #853 for more details. To avoid making a decision on whether to remove the code entirely, I am applying these changes for now to remove completed_job_count. ## 🧪 Validation Unit Testing
laurenkrugen-navapbc
approved these changes
Jul 5, 2024
There was a problem hiding this comment.
had one question, but other than that, LGTM. For the addition of CountUniq, were there possibility of duplicates being reported before?
Validation:
- cleared docker locally and ran process to load fixtures and seed database, with no errors
- ran all tests (unit, postman, etc) with no errors
- did a command search for instances of
completedjobcountandcompleted_job_count, found no references except for one string in ALR that does not need to be changed.
Yes - previously it was relying on completed_job_count so it was potentially inaccurate (although didn't really matter much assuming folks weren't using that response header for critical logic!) |
kyeah
added a commit
that referenced
this pull request
Jul 10, 2024
## 🎫 Ticket https://jira.cms.gov/browse/BCDA-8215 ## 🛠 Changes - Remove completed_job_count column ## ℹ️ Context Removes column from DB after #964 is merged (see related PR for details.) Since migrations are run manually, this can be placed in the same release and run _after_ the application deployment. ## 🧪 Validation Unit tests --------- Co-authored-by: alex-dzeda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
https://jira.cms.gov/browse/BCDA-8215
🛠 Changes
ℹ️ Context
This column, by it's own commented definition, is not a reliable indicator of the number of actually completed sub-jobs for an export job. It appears that its only use is in the in-progress job status header to indicate roughly how far along the job processing is.
Instead of attempting to maintain this field, we should be relying on the source of truth (the number of completed job keys). To avoid confusion and to reduce code complexity, we are removing this column.
Before removing the column from the database, we must stop reading it from the application.
🧪 Validation