Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Further enhance/clarify setup_run_directory #137

Merged
merged 3 commits into from
Apr 2, 2024
Merged

Further enhance/clarify setup_run_directory #137

merged 3 commits into from
Apr 2, 2024

Conversation

navidcy
Copy link
Contributor

@navidcy navidcy commented Mar 29, 2024 •
edited
Loading

Continuing #135

@navidcy navidcy requested a review from angus-g March 29, 2024 05:45
@navidcy navidcy added documentation 📔 Improvements or additions to documentation user experience 📻 labels Mar 29, 2024
ashjbarnes
ashjbarnes approved these changes Apr 2, 2024
View reviewed changes
Copy link
Collaborator

@ashjbarnes ashjbarnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good!

@navidcy navidcy merged commit 4931ce7 into main Apr 2, 2024
5 checks passed
@navidcy navidcy deleted the ncc/setup_run_directory branch April 2, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashjbarnes ashjbarnes ashjbarnes approved these changes

@angus-g angus-g Awaiting requested review from angus-g

Assignees
No one assigned
Labels
documentation 📔 Improvements or additions to documentation user experience 📻
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@navidcy @angus-g @ashjbarnes