-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Paper cc #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Navid C. Constantinou <[email protected]>
Co-authored-by: Navid C. Constantinou <[email protected]>
* AK suggestions * Saved new PDF of paper * tweak acknowledgements Co-authored-by: Navid C. Constantinou <[email protected]> * Saved new PDF of paper * Update paper/paper.md Co-authored-by: Navid C. Constantinou <[email protected]> * Saved new PDF of paper * Update paper/paper.md * Saved new PDF of paper * consult -> dig into a compromise from "decipher" --------- Co-authored-by: aekiss <[email protected]> Co-authored-by: Navid C. Constantinou <[email protected]>
@ChrisC28 can you reopen the PR but towards |
navidcy
requested changes
Apr 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please open the PR from paper_CC
-> joss-paper
branch
Closed and migrated to a PR pointing to joss-paper PR to keep our git history tidy #144 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @ashjbarnes @navidcy
Following @aekiss and making my comments through a PR on a separate branch.
I've made a few mostly minor modifications to the paper.md file. I've included a referece to Mike Herzfeld's work developing the original implementation of the radiation boundary conditions in MOM4, which includes a number of rules-of-thumb regarding regional domain parameters (grid resolution, time step, etc..). I also agree with @aekiss that there was a lot of useful information in the commented out sections of the paper, that, if space isn't an issue, I think could be included.
A few brief comments
Great work so far. I don't think you are far from having something ready to submit.