-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add intro in Docs + include a "MOM6 file structure primer" section #148
Conversation
Co-authored-by: Navid C. Constantinou <[email protected]>
Co-authored-by: Navid C. Constantinou <[email protected]>
Co-authored-by: Navid C. Constantinou <[email protected]>
Co-authored-by: Navid C. Constantinou <[email protected]>
Co-authored-by: Navid C. Constantinou <[email protected]>
Co-authored-by: Navid C. Constantinou <[email protected]>
Co-authored-by: Ashley Barnes <[email protected]>
@ashjbarnes the |
OK. Well it's fair, but I admit it wasn't clear to me! I'll rephrase and ask you to have a look in case I write something wrong! |
Yeah that’s a tricky one. I’d intended for the section to be helpful for troubleshooting for the package but so much of the troubleshooting is linked to mom6. I’ve already made a PR into mom6 docs many months ago but due to the dev cycle those changes still haven’t been merged into main docs. If i push this then it might be 6 months until it appeared publicly, by which point we hope to have the paper well on its way |
OK. We can have this here but somehow the Docs section could be renamed. E.g. it can be a Tutorial of MOM6 or something... |
Yes good you picked this up! Need to explain more carefully. Perhaps need to explain that for rectangular domains the package holds your hand a lot, and for deviations from this people should use the base example and modify it to suit their boundaries. Later on we might have more examples for things like Panan which would be cool! But for now just the one |
Could do. My changes (explaining the data override which I linked in the text of this PR) were merged fairly quickly to the gfdl/dev branch but it seems to take a long time to make its way to the main branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pushed a few changes!
lgtm now!
@ashjbarnes can you have a look at my edits/suggestions? |
If you agree with everything then merge! It's definitely a great start! We can modify later. |
Can we revert this last commit a16bfcd? |
I think it belong to a PR on its own |
OK, perhaps we can leave it. I realised that the segment class is not tested though. |
Co-authored-by: Ashley Barnes <[email protected]>
Segment class is tested along with the expt class I think? Expt calls segment |
Ok cool I'm happy to merge! |
how come the tests didn't break when we changes the segment class from args to kwargs? |
Add explanations about what each input and output file does. There are some general pointers mixed in that I thought of as I went. Intentionally informally written because documentation is often very boring
closes #145