Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add conda-forge and pypi badges + update installation instructions #149

Merged
merged 8 commits into from
Apr 16, 2024
Merged

Add conda-forge and pypi badges + update installation instructions #149

merged 8 commits into from
Apr 16, 2024

Conversation

navidcy
Copy link
Contributor

@navidcy navidcy commented Apr 15, 2024 •
edited
Loading

Closes #6 !!

@navidcy navidcy added documentation 📔 Improvements or additions to documentation package 📦 labels Apr 15, 2024
@navidcy navidcy changed the title Add conda-forge and pypi badges Add conda-forge and pypi badges + update installation instructions Apr 15, 2024
@navidcy navidcy marked this pull request as draft April 15, 2024 20:11
@navidcy
Copy link
Contributor Author

navidcy commented Apr 16, 2024

@angus-g, I'm trying to update the installation instructions.

Question: still after merging in conda-forge, to install regional-mom6 we need to first install esmpy or now conda install conda-forge::regional-mom6 will deal with everything?

@navidcy navidcy requested a review from angus-g April 16, 2024 03:45
@navidcy navidcy marked this pull request as ready for review April 16, 2024 03:45
@angus-g
Copy link
Collaborator

angus-g commented Apr 16, 2024

No, the conda method will pull in all the required dependencies.

@navidcy
Copy link
Contributor Author

navidcy commented Apr 16, 2024

But the pip method won't, right?

@angus-g
Copy link
Collaborator

angus-g commented Apr 16, 2024

Correct, as noted in the xesmf docs: https://xesmf.readthedocs.io/en/latest/installation.html#notes-about-esmpy

@navidcy
Copy link
Contributor Author

navidcy commented Apr 16, 2024

OK, gotcha! Let me update the instructions to reflect this and I'll ping you to review this PR.

@navidcy
Copy link
Contributor Author

navidcy commented Apr 16, 2024

have a look whenever you can @angus-g -- thanks!

@navidcy navidcy mentioned this pull request Apr 16, 2024
Merged
angus-g
angus-g reviewed Apr 16, 2024
View reviewed changes
Copy link
Collaborator

@angus-g angus-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The process is getting cleaner...

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
docs/installation.md Outdated Show resolved Hide resolved
@navidcy
Copy link
Contributor Author

navidcy commented Apr 16, 2024

OK, done with everything!

@navidcy navidcy requested a review from angus-g April 16, 2024 07:19
angus-g
angus-g approved these changes Apr 16, 2024
View reviewed changes
Copy link
Collaborator

@angus-g angus-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, lgtm

@navidcy navidcy merged commit 379cf64 into main Apr 16, 2024
4 checks passed
@navidcy navidcy deleted the ncc/add-badges branch April 16, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angus-g angus-g angus-g approved these changes

Assignees
No one assigned
Labels
documentation 📔 Improvements or additions to documentation joss 📓 package 📦
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set up scripts as a conda package
2 participants
@navidcy @angus-g