Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update install and configuration instructions #259

Merged
merged 1 commit into from
Feb 2, 2023
Merged

Conversation

Zeitsperre
Copy link
Member

@huard

Changes

I've released a new RavenPy conda package that lists OSTRICH as a run_constrained (optional) dependency, i.e. if the dependency is installed, ensure that a specific version of that dependency is installed alongside it.

This means now that ravenpy installed via $ conda install must now explicitly install ostrich as well. This is now reflected in the docs via this PR.

I also removed the steps suggesting cloning the testing data. This has been obsolete for a few months, since #223.

@Zeitsperre Zeitsperre added the documentation Improvements or additions to documentation label Feb 1, 2023
@Zeitsperre Zeitsperre requested a review from huard February 1, 2023 19:06
@Zeitsperre Zeitsperre self-assigned this Feb 1, 2023
@coveralls
Copy link

Pull Request Test Coverage Report for Build 4067816742

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 84.321%

Totals Coverage Status
Change from base Build 4066905083: 0.0%
Covered Lines: 3743
Relevant Lines: 4439

💛 - Coveralls

@huard
Copy link
Collaborator

huard commented Feb 1, 2023

@Mayetea Veux-tu valider de ton côté que les instructions sont claires?

@Mayetea
Copy link
Collaborator

Mayetea commented Feb 2, 2023

Les modifs semblent clairs, mais je vais essayer le tout dans un nouvel environnement, demain matin!

@Mayetea
Copy link
Collaborator

Mayetea commented Feb 2, 2023

Les binairies semblent bien s'installer. Je n'ai plus d'erreurs comme quoi les binairie_path sont introuvable. J'ai d'autres erreurs, mais ça semble pas être relié à l'installation.

Copy link
Collaborator

@Mayetea Mayetea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Binairies are well installed, and the procedure is clear.

@huard huard merged commit a9b6bc6 into master Feb 2, 2023
@huard huard deleted the dev_doc_fixes branch February 2, 2023 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants