Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2023.3.1 #2827

Merged
merged 6 commits into from
Feb 20, 2024
Merged

Release 2023.3.1 #2827

merged 6 commits into from
Feb 20, 2024

Conversation

hurricup
Copy link
Collaborator

No description provided.

Some DSL may produce several entities by a single identifier, e.g. mk_accessors may create getter and setter. We should avoid marking them twice as deprecated.
@hurricup hurricup enabled auto-merge (rebase) February 20, 2024 05:19
Copy link

Qodana for JVM

2724 new problems were found

Inspection name Severity Problems
Usage of API marked for removal 🔴 Failure 24
Missorted modifiers 🔶 Warning 613
Unused declaration 🔶 Warning 596
Deprecated API usage 🔶 Warning 249
Missing '@Override' annotation 🔶 Warning 212
Method can be made 'void' 🔶 Warning 78
Check dependency licenses 🔶 Warning 75
Method parameter always has the same value 🔶 Warning 46
Method always returns the same value 🔶 Warning 38
Hardcoded strings 🔶 Warning 35
@NotNull/@Nullable problems 🔶 Warning 34
'size() == 0' can be replaced with 'isEmpty()' 🔶 Warning 27
Class is exposed outside of its visibility scope 🔶 Warning 25
Static initialization in extension point implementations 🔶 Warning 25
Method is identical to its super method 🔶 Warning 21
Unnecessary semicolon 🔶 Warning 21
Declaration can have 'final' modifier 🔶 Warning 16
Non-platform TokenSet declared in ParserDefinition 🔶 Warning 16
Can use bounded wildcard 🔶 Warning 14
Redundant 'throws' clause 🔶 Warning 11
Field may be 'final' 🔶 Warning 9
C-style array declaration 🔶 Warning 7
'final' method in 'final' class 🔶 Warning 3
Plugin.xml dynamic plugin verification 🔶 Warning 3
Raw use of parameterized class 🔶 Warning 3
Incorrect string capitalization 🔶 Warning 2
Missing required 'lang' attribute 🔶 Warning 2
A service can be converted to a light one 🔶 Warning 2
Statement lambda can be replaced with expression lambda 🔶 Warning 1
Explicit type can be replaced with '<>' 🔶 Warning 1
Lambda can be replaced with method reference 🔶 Warning 1
'protected' member in 'final' class 🔶 Warning 1
Unnecessary conversion to 'String' 🔶 Warning 1
Unnecessary modifier 🔶 Warning 1
Duplicate branches in 'switch' ◽️ Notice 505
Method can be extracted ◽️ Notice 5
Immutable collection creation can be replaced with collection factory call ◽️ Notice 1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at [email protected]

/**
* fixme butify this
*/
public class PerlDeprecatedInspection extends PerlInspection {
@Override
public @NotNull PsiElementVisitor buildVisitor(final @NotNull ProblemsHolder holder, boolean isOnTheFly) {
return new PerlVisitor() {
private Set<PsiElement> myMarkedElements = new HashSet<>();

Check warning

Code scanning / QDJVM

Declaration can have 'final' modifier Warning

Declaration can have final modifier
/**
* fixme butify this
*/
public class PerlDeprecatedInspection extends PerlInspection {
@Override
public @NotNull PsiElementVisitor buildVisitor(final @NotNull ProblemsHolder holder, boolean isOnTheFly) {
return new PerlVisitor() {
private Set<PsiElement> myMarkedElements = new HashSet<>();

Check warning

Code scanning / QDJVM

Field may be 'final' Warning

Field myMarkedElements may be 'final'
@hurricup hurricup merged commit a015269 into master Feb 20, 2024
36 checks passed
@hurricup hurricup deleted the dev/233 branch February 20, 2024 06:02
@coveralls
Copy link

Coverage Status

coverage: 82.091% (-0.01%) from 82.101%
when pulling 599165c on dev/233
into 34a6a35 on master.

Copy link

sonarcloud bot commented Feb 20, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants