Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 2023.3.1 #2827

Merged
merged 6 commits into from
Feb 20, 2024
Merged

Release 2023.3.1 #2827

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
374fbb4
Build vs 2023.3
hurricup Feb 20, 2024
a41fb27
Skip implicit compiling for the SonarLint
hurricup Feb 17, 2024
02b26cb
Do not mark poly-named elements twice
hurricup Feb 17, 2024
4a460d0
Do not bundle kotlin stdlib into plugin, provided by the platform
hurricup Feb 17, 2024
728822b
Fixed form binding class
hurricup Feb 17, 2024
599165c
Release 2023.3.1
hurricup Feb 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .idea/encodings.xml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 5 additions & 4 deletions gradle.properties
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,12 @@
# https://www.jetbrains.com/intellij-repository/releases
# https://www.jetbrains.com/intellij-repository/snapshots
name="Perl5 Support (Camelcade)"
platformVersion=233
platformBranch=.11799.196-EAP-SNAPSHOT
platformVersion=2023
platformBranch=.3
platformBuild=
pluginVersion=2023
pluginBranch=.3
pluginBuild=
pluginBranch=
pluginBuild=.1
pycharmVersion=192.4787.5-EAP-SNAPSHOT
clionVersion=192.4787.12-EAP-SNAPSHOT
psiViewerVersion=233.2
Expand All @@ -38,3 +38,4 @@ descriptionFile=parts/pluginDescription.html
changesFile=parts/pluginChanges.html
org.gradle.jvmargs=-Xmx2048m -XX:+HeapDumpOnOutOfMemoryError -Xss10M
perl.test.version=5.38.0
kotlin.stdlib.default.dependency=false
7 changes: 6 additions & 1 deletion plugin/core/src/main/java/com/perl5/lang/perl/idea/inspections/PerlDeprecatedInspection.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,13 +25,18 @@
import com.perl5.lang.perl.psi.utils.PerlResolveUtil;
import org.jetbrains.annotations.NotNull;

import java.util.HashSet;
import java.util.Set;

/**
* fixme butify this
*/
public class PerlDeprecatedInspection extends PerlInspection {
@Override
public @NotNull PsiElementVisitor buildVisitor(final @NotNull ProblemsHolder holder, boolean isOnTheFly) {
return new PerlVisitor() {
private Set<PsiElement> myMarkedElements = new HashSet<>();

Check warning on line 38 in plugin/core/src/main/java/com/perl5/lang/perl/idea/inspections/PerlDeprecatedInspection.java

View workflow job for this annotation

GitHub Actions / Qodana for JVM

Declaration can have 'final' modifier 

Declaration can have final modifier

Check warning on line 38 in plugin/core/src/main/java/com/perl5/lang/perl/idea/inspections/PerlDeprecatedInspection.java

View workflow job for this annotation

GitHub Actions / Qodana for JVM

Field may be 'final' 

Field `myMarkedElements` may be 'final'

Check warning

Code scanning / QDJVM

Declaration can have 'final' modifier Warning

Declaration can have final modifier

Check warning

Code scanning / QDJVM

Field may be 'final' Warning

Field myMarkedElements may be 'final'

@Override
public void visitSubNameElement(@NotNull PerlSubNameElement o) {
PsiElement container = o.getParent();
Expand Down Expand Up @@ -93,7 +98,7 @@
public void visitPerlSubElement(@NotNull PerlSubElement o) {
if (o.isDeprecated()) {
PsiElement nameIdentifier = o.getNameIdentifier();
if (nameIdentifier != null) {
if (nameIdentifier != null && myMarkedElements.add(nameIdentifier)) {
markDeprecated(holder, nameIdentifier, PerlBundle.message("perl.deprecated.sub"));
}
}
Expand Down
27 changes: 0 additions & 27 deletions ...n/java/com/perl5/lang/perl/idea/configuration/module/idea/PerlDumbModuleConfigurable.form
View file
Open in desktop

This file was deleted.

1 change: 1 addition & 0 deletions settings.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,3 +85,4 @@ include("lang.mason.htmlmason")
project(":lang.mason.htmlmason").projectDir = file("mason/htmlmason")
include("lang.mason.htmlmason:core")
project(":lang.mason.htmlmason:core").projectDir = file("mason/htmlmason/core")
System.setProperty("sonar.gradle.skipCompile", "true")
Loading