Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add YAML-based ThermoBuild tutorial #161

Merged
merged 2 commits into from
Jan 27, 2022
Merged

Add YAML-based ThermoBuild tutorial #161

merged 2 commits into from
Jan 27, 2022

Conversation

speth
Copy link
Member

@speth speth commented Nov 20, 2021

  • Add updated NASA ThermoBuild tutorial based on YAML format. The old version of this is embedded in the CTI tutorial and will get deleted when those docs go away.
  • Fix the URL for ThermoBuild, which has apparently changed.
  • Specify use of the ruamel.yaml conda package instead of ruamel_yaml. This parallels a change made in Miscellanous small improvements cantera#1140.

@bryanwweber
Copy link
Member

The ruamel.yaml changes are related to this issue: conda-forge/ruamel_yaml-feedstock#1 and this issue: conda-forge/ruamel.yaml-feedstock#7 Unfortunately, the relevant discussion and history on the ruamel-yaml project has been deleted, since Bitbucket decided to stop supporting Mercurial and the author moved the code to Sourceforge.

ischoegl
ischoegl reviewed Nov 22, 2021
View reviewed changes
Copy link
Member

@ischoegl ischoegl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just looked at the rendered output based on the CI artifacts, and the tutorial looks good to me (although I haven't tested it).

@bryanwweber bryanwweber self-assigned this Jan 18, 2022
@bryanwweber bryanwweber self-requested a review January 18, 2022 03:13
@bryanwweber bryanwweber removed their assignment Jan 18, 2022
ischoegl
ischoegl requested changes Jan 20, 2022
View reviewed changes
Copy link
Member

@ischoegl ischoegl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@speth ... I ran through your instructions and most of this is straight-forward. I did find some minor points though.

pages/tutorials/thermobuild.rst Outdated Show resolved Hide resolved
pages/tutorials/thermobuild.rst Outdated Show resolved Hide resolved
pages/tutorials/thermobuild.rst Outdated Show resolved Hide resolved
pages/tutorials/thermobuild.rst Outdated Show resolved Hide resolved
@speth
Specify use of ruamel.yaml conda package instead of ruamel_yaml
069b312
@speth
Add updated NASA ThermoBuild tutorial based on YAML format
990d75e 
The old version of this is embedded in the CTI tutorial and will get
deleted when those docs go away.
@speth
Copy link
Member Author

speth commented Jan 27, 2022

Thanks for catching those issues, @ischoegl. I think this is good to go now.

@ischoegl ischoegl merged commit f0306db into Cantera:main Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ischoegl ischoegl ischoegl requested changes

@bryanwweber bryanwweber Awaiting requested review from bryanwweber

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@speth @bryanwweber @ischoegl