Miscellanous small improvements #1140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compiling this regex every time a Units object was created from a string was resulting in a noticeable slowdown when importing larger mechanisms.
The ruamel_yaml package name was only ever used by Anaconda. They have now adopted the ruamel.yaml name. The ruamel_yaml package is no longer up-to-date, so we should default to using ruamel.yaml and only fall back to ruamel_yaml if necessary, rather than the other way around.
Printing the input string that causes the error helps users find problematic input.
Codecov Report
@@ Coverage Diff @@
## main #1140 +/- ##
=======================================
Coverage 73.49% 73.49%
=======================================
Files 365 365
Lines 48187 48187
=======================================
Hits 35417 35417
Misses 12770 12770
Continue to review full report at Codecov.
|
ischoegl
approved these changes
Nov 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request
fpValueCheckChecklist
scons build&scons test) and unit tests address code coverage