-
-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix conda example packaging #1366
Conversation
d8da871
to
b52756f
Compare
164e91d
to
17dfd49
Compare
17dfd49
to
b83357b
Compare
b83357b
to
554df41
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes sense to me, in general. I have just a few questions / suggestions related to a few of the implementation details.
554df41
to
1f02fef
Compare
Do not include folders outside of package environment
1f02fef
to
d710204
Compare
@speth ... thanks for the review! I addressed all comments - overall, I believe this PR should fix most remaining issues for On a separate note, for the last action, all 18.04 ubuntu runners were cancelled. |
Codecov Report
@@ Coverage Diff @@
## main #1366 +/- ##
==========================================
- Coverage 70.93% 70.89% -0.04%
==========================================
Files 356 357 +1
Lines 51471 51500 +29
Branches 17189 17198 +9
==========================================
Hits 36510 36510
- Misses 12667 12696 +29
Partials 2294 2294
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Changes proposed in this pull request
package_build
package_build=y
), exclude 'include' and 'library' paths outside of build and host enviroments in development sampleMakefile
's andSConstruct
's, as well asinclude/cantera/Cantera.mak
and/lib/pkgconfig/cantera.pc
PR ensures that
libcantera-devel
packages all C++ and Fortran examples without referencing the build environment.If applicable, fill in the issue number this pull request is fixing
Closes Cantera/conda-recipes#37
If applicable, provide an example illustrating new features this pull request is introducing
With an updated
conda-recipes
using the SCons flagpackage_build=y
, the following will workC++ examples can be compiled with preconfigured build tools:
Same for Fortran F90 (and F77):
Checklist
scons build
&scons test
) and unit tests address code coverage