Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add standard CI cases using Python 3.13 #1808

Merged
merged 2 commits into from
Nov 10, 2024
Merged

Conversation

speth
Copy link
Member

@speth speth commented Nov 7, 2024

Changes proposed in this pull request

  • Add standard CI runs using Python 3.13
  • Update macOS runner version to include the most recent one (macos-15) and drop macos-12 which is pending removal by GitHub

The one test failure is caused by the example that uses CoolProp, which has not yet been updated for Python 3.13.

Checklist

  • The pull request includes a clear description of this code change
  • Commit messages have short titles and reference relevant issues
  • Build passes (scons build & scons test) and unit tests address code coverage
  • Style & formatting of contributed code follows contributing guidelines
  • The pull request is ready for review

@speth speth added the CI label Nov 7, 2024
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.26%. Comparing base (e36c9b9) to head (2dfeada).
Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1808   +/-   ##
=======================================
  Coverage   73.26%   73.26%           
=======================================
  Files         383      383           
  Lines       54620    54620           
  Branches     9099     9099           
=======================================
  Hits        40016    40016           
  Misses      11601    11601           
  Partials     3003     3003           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bryanwweber
Copy link
Member

Fortunately, pint 0.24.4 was just released that resolves hgrecco/pint#1969, so Python 3.13 tests won't fail for that reason!

macos-12 is deprecated, and macos-15 is now available
@speth speth marked this pull request as ready for review November 10, 2024 18:37
@speth speth mentioned this pull request Nov 10, 2024
5 tasks
Copy link
Member

@ischoegl ischoegl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This all looks good to me! (The one failing example appears to be an upstream issue in CoolProp)

@speth speth merged commit c77e807 into Cantera:main Nov 10, 2024
58 of 59 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants