Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag beta version for Cantera 3.1.0 #1810

Merged
merged 2 commits into from
Nov 11, 2024
Merged

Tag beta version for Cantera 3.1.0 #1810

merged 2 commits into from
Nov 11, 2024

Conversation

speth
Copy link
Member

@speth speth commented Nov 10, 2024

Changes proposed in this pull request

  • Draft release notes for Cantera 3.1.0
  • Bump version to 3.1.0b1 (this should be the tagged commit)

This should be merged after #1808.

Checklist

  • The pull request includes a clear description of this code change
  • Commit messages have short titles and reference relevant issues
  • Build passes (scons build & scons test) and unit tests address code coverage
  • Style & formatting of contributed code follows contributing guidelines
  • The pull request is ready for review

Copy link

codecov bot commented Nov 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.26%. Comparing base (e36c9b9) to head (35849bc).
Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1810   +/-   ##
=======================================
  Coverage   73.26%   73.26%           
=======================================
  Files         383      383           
  Lines       54620    54620           
  Branches     9099     9099           
=======================================
  Hits        40016    40016           
  Misses      11601    11601           
  Partials     3003     3003           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@speth speth marked this pull request as ready for review November 10, 2024 23:00
Copy link
Member

@ischoegl ischoegl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume that #1704 and a fix for #1806 would be added during the beta phase?

@speth
Copy link
Member Author

speth commented Nov 11, 2024

Hopefully and yes, respectively. I don't think there's a need to hold the beta for either of these.

@ischoegl ischoegl merged commit 70521b7 into Cantera:main Nov 11, 2024
52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants