Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor changes to CONTRIBUTING.md #856

Merged
merged 2 commits into from
Jun 1, 2020
Merged

Conversation

decaluwe
Copy link
Member

  • Added reference to new Cantera/enhancements GitHub repo.
  • Added explicit instruction to push to forked copy of the repo, before submitting a PR.

Checklist

  • There is a clear use-case for this code change
  • The commit message has a short title & references relevant issues
  • Build passes (scons build & scons test) and unit tests address code coverage
  • The pull request is ready for review

Changes proposed in this pull request

  • Minor updates to the instructions in CONTRIBUTING.md

- Added reference to new `Cantera/enhancements` GitHub repo.
- Added explicit instruction to push to forked copy of the repo, before
submitting a PR.
@codecov
Copy link

codecov bot commented May 30, 2020

Codecov Report

Merging #856 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #856   +/-   ##
=======================================
  Coverage   71.40%   71.40%           
=======================================
  Files         372      372           
  Lines       43605    43605           
=======================================
  Hits        31134    31134           
  Misses      12471    12471           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0089281...d2a5c5b. Read the comment docs.

@bryanwweber
Copy link
Member

@decaluwe If you agree with my change, feel free to merge 👍

@decaluwe decaluwe merged commit f973215 into Cantera:master Jun 1, 2020
srikanthallu pushed a commit to srikanthallu/cantera that referenced this pull request Sep 17, 2020
* Minor changes to CONTRIBUTING.md

- Added reference to new `Cantera/enhancements` GitHub repo.
- Added explicit instruction to push to forked copy of the repo, before
submitting a PR.

* Add link to Cantera/enhancements

Co-authored-by: Bryan W. Weber <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants