Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor changes to CONTRIBUTING.md #856

Merged
merged 2 commits into from
Jun 1, 2020
Merged

Minor changes to CONTRIBUTING.md #856

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d593486
Minor changes to CONTRIBUTING.md
decaluwe May 30, 2020
d2a5c5b
Add link to Cantera/enhancements
bryanwweber Jun 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 9 additions & 5 deletions CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
# Contributing to Cantera

* For significant changes, consider starting a discussion on the Cantera
Users' Group to plan your modifications so that they can be implemented
* For significant changes, please start a discussion on the Cantera
Users' Group or create an issue on the [Cantera/enhancements](https://github.com/Cantera/enhancements/issues/new/choose) repository
on GitHub to plan your modifications so that they can be implemented
efficiently and in a way that doesn't conflict with any other planned
future development
* Fork the `Cantera/cantera` repository on Github
Expand Down Expand Up @@ -29,9 +30,12 @@
onto the most recent `HEAD` commit of `master`.
* Periodically run the test suite (`scons test`) to make sure that your
changes are not causing any test failures.
* Submit a Pull Request on Github. Check the results of the continuous-
integration tests run using Travis and AppVeyor and resolve any issues that
arise.
* Push the changes on your new feature branch to your forked copy of the
`Cantera/cantera` repository on GitHub.

* Submit a Pull Request on Github, from your forked copy. Check the results
of the continuous-integration tests run using Travis and AppVeyor and resolve
any issues that arise.
* Additional discussion of good Git & Github workflow is provided at
http://matplotlib.org/devel/gitwash/development_workflow.html and
https://docs.scipy.org/doc/numpy-1.15.0/dev/gitwash/development_workflow.html
Expand Down