Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: pyproject.xml fixes #171

Merged
merged 2 commits into from
Apr 11, 2024
Merged

Build: pyproject.xml fixes #171

merged 2 commits into from
Apr 11, 2024

Conversation

mgorny
Copy link
Contributor

@mgorny mgorny commented Aug 22, 2023

commit 97498ae
Author: Michał Górny [email protected]
AuthorDate: 2023-08-22 05:54:54 +0200
Commit: Michał Górny [email protected]
CommitDate: 2023-08-22 05:55:20 +0200

Build: Remove redundant wheel dep from pyproject.toml

Remove the redundant `wheel` dependency, as it is added by the backend
automatically.  Listing it explicitly in the documentation was
a historical mistake and has been fixed since, see:
https://github.com/pypa/setuptools/commit/f7d30a9529378cf69054b5176249e5457aaf640a

commit df8e407
Author: Michał Górny [email protected]
AuthorDate: 2023-08-22 05:50:07 +0200
Commit: Michał Górny [email protected]
CommitDate: 2023-08-22 05:50:07 +0200

Build: Use non-legacy setuptools backend

Use the modern `setuptools.build_meta` backend rather than the legacy
backend that is implied by the lack of `build-backend`.

This is documented in PEP 517:

> If the `pyproject.toml` file is absent, or the `build-backend` key is
> missing, the source tree is not using this specification, and tools
> should revert to the legacy behaviour of running `setup.py` (either
> directly, or by implicitly invoking
> the `setuptools.build_meta:__legacy__` backend).

https://peps.python.org/pep-0517/#source-trees

Use the modern `setuptools.build_meta` backend rather than the legacy
backend that is implied by the lack of `build-backend`.

This is documented in PEP 517:

> If the `pyproject.toml` file is absent, or the `build-backend` key is
> missing, the source tree is not using this specification, and tools
> should revert to the legacy behaviour of running `setup.py` (either
> directly, or by implicitly invoking
> the `setuptools.build_meta:__legacy__` backend).

https://peps.python.org/pep-0517/#source-trees
Remove the redundant `wheel` dependency, as it is added by the backend
automatically.  Listing it explicitly in the documentation was
a historical mistake and has been fixed since, see:
pypa/setuptools@f7d30a9
@codecov-commenter
Copy link

codecov-commenter commented Aug 22, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (2d23294) 91.71% compared to head (97498ae) 91.77%.
Report is 6 commits behind head on develop.

Files Patch % Lines
src/pygccxml/parser/linker.py 0.00% 1 Missing ⚠️
src/pygccxml/utils/utils.py 50.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #171      +/-   ##
===========================================
+ Coverage    91.71%   91.77%   +0.05%     
===========================================
  Files          138      138              
  Lines        10736    10720      -16     
===========================================
- Hits          9847     9838       -9     
+ Misses         889      882       -7     
Flag Coverage Δ
unittests 91.77% <85.71%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@thewtex thewtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@iMichka iMichka merged commit 914ff60 into CastXML:develop Apr 11, 2024
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants