Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: explicitly specify macos runner version #174

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

thewtex
Copy link
Contributor

@thewtex thewtex commented Apr 9, 2024

The castxml binary is for Intel macOS -> point to macos-12.

@thewtex thewtex requested a review from iMichka April 9, 2024 21:04
@thewtex
Copy link
Contributor Author

thewtex commented Apr 9, 2024

@iMichka the CodeCov token is out-of-date? Do you have an update or should we remove?

The castxml binary is for Intel macOS -> point to macos-12.
@iMichka
Copy link
Contributor

iMichka commented Apr 10, 2024

I removed codecov for the time being (#175) and rebased your PR.
I don't remember having access to codecov but I need to double check.

The failures are unrelated on macOS: I know these tests are broken but the fix is not that easy (some fiddling around with template whitespaces have to be done ... or rewriting a lot of logic to get it right on all the platforms).

@iMichka iMichka merged commit 80997c2 into CastXML:develop Apr 10, 2024
7 of 8 checks passed
@thewtex
Copy link
Contributor Author

thewtex commented Apr 11, 2024

@iMichka thanks!

If the failures are unrelated, we can also merge #171 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants