Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MapViewer fixes for #228 #262

Merged
merged 6 commits into from
Jan 7, 2015
Merged

MapViewer fixes for #228 #262

merged 6 commits into from
Jan 7, 2015

Conversation

tobykurien
Copy link
Contributor

No description provided.

@SecUpwN
Copy link
Member

SecUpwN commented Jan 7, 2015

Oh hey, this gotta be your New Years Pull Request, huh? Many thanks, so WOW! :trollface: Just a quick question before I merge this: Could you please verify if E:V:A did this right, @tobykurien? It seems as if we now have different sizes in the drawable folders, not sure if that is correct. He wanted to tackle #250.

@tobykurien
Copy link
Contributor Author

@SecUpwN no the icons are incorrectly sized - it looks like he just copied the same icons into all the folders. @E3V3A you need to read this https://developer.android.com/training/basics/supporting-devices/screens.html#create-bitmaps

@SecUpwN
Copy link
Member

SecUpwN commented Jan 7, 2015

@tobykurien, thanks for confirming my intitial thoughts. I guess E:V:A just introduced this "hotfix" because he was annoyed of the pins being too large. Can those Icons be made generic in size?

I just noticed and understood that since we're using an overlay (AFAIK), the icons doesn't scale down with the map when you zoom out. Thus they remain relatively huge, when zooming out. This make them look ugly and get bloated out with each other. We need to use non-overlay icons if possible.

Before merging your great pull request here, can we focus on fixing #250, please? What do I need to do really fix that Issue? I guess changing the map pins to the correct sizes for each folder isn't enough?

@tobykurien
Copy link
Contributor Author

I don't understand what needs to be done with #250 at all. Besides the fact that the pins have now been modified, so I don't even know what the current status of pin colors is. It also mentions DBe_import, which I am not familiar with yet. Finally, I don't see how that needs to stop you merging the pull request.

@SecUpwN
Copy link
Member

SecUpwN commented Jan 7, 2015

Finally, I don't see how that needs to stop you merging the pull request.

@tobykurien, it actually doesn't. I was just thinking you could tell me what to do about #250.

SecUpwN added a commit that referenced this pull request Jan 7, 2015
@SecUpwN SecUpwN merged commit 3c78ec6 into CellularPrivacy:master Jan 7, 2015
@E3V3A
Copy link
Contributor

E3V3A commented Jan 7, 2015

@tobykurien Awesome! Also, I've tried to clarify # 250 for you.

SecUpwN added a commit that referenced this pull request Apr 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants