-
Notifications
You must be signed in to change notification settings - Fork 949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MapViewer fixes for #228 #262
Conversation
Oh hey, this gotta be your New Years Pull Request, huh? Many thanks, so WOW! Just a quick question before I merge this: Could you please verify if E:V:A did this right, @tobykurien? It seems as if we now have different sizes in the drawable folders, not sure if that is correct. He wanted to tackle #250. |
@SecUpwN no the icons are incorrectly sized - it looks like he just copied the same icons into all the folders. @E3V3A you need to read this https://developer.android.com/training/basics/supporting-devices/screens.html#create-bitmaps |
@tobykurien, thanks for confirming my intitial thoughts. I guess E:V:A just introduced this "hotfix" because he was annoyed of the pins being too large. Can those Icons be made generic in size?
Before merging your great pull request here, can we focus on fixing #250, please? What do I need to do really fix that Issue? I guess changing the map pins to the correct sizes for each folder isn't enough? |
I don't understand what needs to be done with #250 at all. Besides the fact that the pins have now been modified, so I don't even know what the current status of pin colors is. It also mentions DBe_import, which I am not familiar with yet. Finally, I don't see how that needs to stop you merging the pull request. |
@tobykurien, it actually doesn't. I was just thinking you could tell me what to do about #250. |
@tobykurien Awesome! Also, I've tried to clarify # 250 for you. |
No description provided.