Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for using webpack 5. Please review #25

Closed
wants to merge 5 commits into from

Conversation

petrushy
Copy link

@petrushy petrushy commented Feb 9, 2021

A PR for building using webpack 5. It is working but please review, I am by no means an expert in this area.

Especially regarding the import of .css in the src/index.js I think is likely not the right way to do it, but cannot find another way without a protest regarding the exports in cesium:

import "../dist/Widgets/widgets.css"

@petrushy petrushy mentioned this pull request Feb 10, 2021
@goldenram
Copy link

Any progress made on this? We are trying to update our project to use Webpack 5 and the Cesium library is the only library blocking completing that task. Thanks!

@petrushy
Copy link
Author

petrushy commented Mar 1, 2021

Hi, It works it seems and I also realized there is another PR with webpack 5 #23

But would be good if someone with more insight reviewed this / that.

@boeckMt
Copy link

boeckMt commented Oct 13, 2021

Hey I think there are now three PR's with similar stuff. Maybe someone can link/merge #28. #23, #25 together?

@maylortaylor
Copy link

I am getting a ReferenceError: __dirname is not defined in the index.cjs file at the point below:
module.exports = webpack_require("../../node_modules/cesium sync recursive")(path.join(
__dirname,
"Build/CesiumUnminified/index.cjs"
));

@jjspace
Copy link
Contributor

jjspace commented Jan 3, 2024

replaced by #52

@jjspace jjspace closed this Jan 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants