Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update webpack dependencies and config #52

Merged
merged 2 commits into from
Jan 5, 2024
Merged

update webpack dependencies and config #52

merged 2 commits into from
Jan 5, 2024

Conversation

jjspace
Copy link
Contributor

@jjspace jjspace commented Jan 3, 2024

We are basically already inline with the correct ways to do webpack 5. This just updates the config slightly to demonstrate setting a static path and updates the related package versions.

I also added a npm run start:built to demonstrate hosting the built version as static files using http-server

This branches off of #51

Fixes #24
Fixes #11
Fixes #4

webpack.config.js Outdated Show resolved Hide resolved
Base automatically changed from fix-example-page to main January 4, 2024 14:19
@ggetz
Copy link
Contributor

ggetz commented Jan 5, 2024

Looks good to me! Thanks @jjspace!

@ggetz ggetz merged commit f5ecccb into main Jan 5, 2024
2 checks passed
@ggetz ggetz deleted the webpack-5-update branch January 5, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

webpack 5 example Base url issue Also copy ThirdParty/Workers
3 participants