Skip to content

Commit

Permalink
Fix github action warnings (#5078)
Browse files Browse the repository at this point in the history
  • Loading branch information
twoeths committed Jan 30, 2023
1 parent a889940 commit adb2309
Show file tree
Hide file tree
Showing 12 changed files with 31 additions and 29 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/benchmark.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@ jobs:
steps:
# <common-build> - Uses YAML anchors in the future
- uses: actions/checkout@v2
- uses: actions/setup-node@v2
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: 18
- name: Node.js version
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/docs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,8 @@ jobs:
runs-on: ubuntu-latest
steps:
# <common-build> - Uses YAML anchors in the future
- uses: actions/checkout@v2
- uses: actions/setup-node@v2
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: 18
- name: Node.js version
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/publish-dev.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,10 @@ jobs:
runs-on: ubuntu-latest
steps:
# <common-build> - Uses YAML anchors in the future
- uses: actions/checkout@v2
- uses: actions/checkout@v3
with:
fetch-depth: 0
- uses: actions/setup-node@v2
- uses: actions/setup-node@v3
with:
node-version: 18
registry-url: "https://registry.npmjs.org"
Expand Down Expand Up @@ -107,7 +107,7 @@ jobs:
runs-on: ubuntu-latest
needs: npm
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
# https://github.com/docker/setup-qemu-action
- name: Set up QEMU
uses: docker/setup-qemu-action@v1
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/publish-rc.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout code
uses: actions/checkout@v2
uses: actions/checkout@v3
with:
fetch-depth: 0

Expand Down Expand Up @@ -49,7 +49,7 @@ jobs:
if: needs.tag.outputs.is_rc == 'true'
steps:
# <common-build> - Uses YAML anchors in the future
- uses: actions/checkout@v2
- uses: actions/checkout@v3
with:
fetch-depth: 0 # Needs full depth for changelog generation
- uses: actions/setup-node@v2
Expand Down Expand Up @@ -130,7 +130,7 @@ jobs:
needs: [tag, npm]
if: needs.tag.outputs.is_rc == 'true'
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
- run: scripts/await-release.sh ${{ needs.tag.outputs.tag }} rc 900
# https://github.com/docker/setup-qemu-action
- name: Set up QEMU
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/publish-stable.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Checkout code
uses: actions/checkout@v2
uses: actions/checkout@v3
with:
fetch-depth: 0

Expand Down Expand Up @@ -55,10 +55,10 @@ jobs:
if: needs.tag.outputs.is_stable == 'true'
steps:
# <common-build> - Uses YAML anchors in the future
- uses: actions/checkout@v2
- uses: actions/checkout@v3
with:
fetch-depth: 0 # Needs full depth for changelog generation
- uses: actions/setup-node@v2
- uses: actions/setup-node@v3
with:
node-version: 18
- name: Node.js version
Expand Down Expand Up @@ -120,7 +120,7 @@ jobs:
needs: [tag, npm]
if: needs.tag.outputs.is_stable == 'true'
steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v3
- run: scripts/await-release.sh ${{ needs.tag.outputs.tag }} latest 900
# https://github.com/docker/setup-qemu-action
- name: Set up QEMU
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/test-browser.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,11 +17,11 @@ jobs:
node: [18]
steps:
# <common-build> - Uses YAML anchors in the future
- uses: actions/checkout@v2
- uses: actions/checkout@v3
- uses: browser-actions/setup-firefox@latest
with:
firefox-version: "latest"
- uses: actions/setup-node@v2
- uses: actions/setup-node@v3
with:
node-version: ${{matrix.node}}
- name: Node.js version
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/test-e2e.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@ jobs:
node: [18]
steps:
# <common-build> - Uses YAML anchors in the future
- uses: actions/checkout@v2
- uses: actions/setup-node@v2
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: ${{matrix.node}}
- name: Node.js version
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/test-sim-merge.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ jobs:
runs-on: ubuntu-latest
steps:
# <common-build> - Uses YAML anchors in the future
- uses: actions/checkout@v2
- uses: actions/setup-node@v2
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: 18
- name: Node.js version
Expand Down Expand Up @@ -89,7 +89,7 @@ jobs:
name: debug-test-logs
path: packages/beacon-node/test-logs

# - name: Pull geth withdrawals
# - name: Pull geth withdrawals
# run: docker pull $GETH_WITHDRAWALS_IMAGE

# - name: Test Lodestar <> geth withdrawals
Expand All @@ -99,7 +99,7 @@ jobs:
# EL_BINARY_DIR: ${{ env.GETH_WITHDRAWALS_IMAGE }}
# EL_SCRIPT_DIR: gethdocker

# - name: Pull ethereumjs withdrawals
# - name: Pull ethereumjs withdrawals
# run: docker pull $ETHEREUMJS_WITHDRAWALS_IMAGE

# - name: Test Lodestar <> ethereumjs withdrawals
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/test-sim.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ jobs:
runs-on: ubuntu-latest
steps:
# <common-build> - Uses YAML anchors in the future
- uses: actions/checkout@v2
- uses: actions/setup-node@v2
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: 18
- name: Node.js version
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/test-spec.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,8 @@ jobs:
# - run: ./scripts/free-disk-space.sh

# <common-build> - Uses YAML anchors in the future
- uses: actions/checkout@v2
- uses: actions/setup-node@v2
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: 18
- name: Node.js version
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@ jobs:
node: [18]
steps:
# <common-build> - Uses YAML anchors in the future
- uses: actions/checkout@v2
- uses: actions/setup-node@v2
- uses: actions/checkout@v3
- uses: actions/setup-node@v3
with:
node-version: ${{matrix.node}}
- name: Node.js version
Expand Down
4 changes: 3 additions & 1 deletion scripts/get_prev_tag.js
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,9 @@ async function run() {
const tags = stdout.trim().split("\n");
for (const tag of tags) {
if (tag !== CURRENT_TAG && !tag.includes(IGNORE_PATTERN)) {
console.log(`::set-output name=prev_tag::${tag}`);
const cmd = `echo "prev_tag=${tag}" >> ${process.env.GITHUB_OUTPUT}`;
console.log("Execute command on shell", cmd);
await promisify(exec)(cmd);
return;
}
}
Expand Down

0 comments on commit adb2309

Please sign in to comment.