Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Numbers design decision #94

Closed
GregTheGreek opened this issue Feb 8, 2019 · 3 comments
Closed

Numbers design decision #94

GregTheGreek opened this issue Feb 8, 2019 · 3 comments

Comments

@GregTheGreek
Copy link
Member

As per our discussion on 08/02/19 with @JonathanLorimer @wemeetagain @GregTheGreek @ansermino

We have decided to temporarily take focus off of fixed-size-number-ts and explore using big numbers.

We could utilize javascript number api for everything under 2**53 - 1 (i.e uint8, uint16, ....).

Any notes I missed please add them.

@tynes
Copy link

tynes commented Feb 25, 2019

Node.js LTS has added BigInts [1], they are seeing some usage in Handshake [2]. Might be useful for the BLS Signatures

[1] https://developers.google.com/web/updates/2018/05/bigint
[2] https://github.com/handshake-org/goosig/blob/master/lib/js/bigmath.js

@wemeetagain
Copy link
Member

@tynes
Thanks for the heads up!
I think we'd love to use native BigInts if possible, though it may take us a while to migrate in that direction. Some thoughts in no particular order:

@tynes
Copy link

tynes commented Feb 25, 2019

Thanks for sharing all of this! We have a bunch of good JS tools over here at bcoin/handshake and I'm rooting for y'all and looking for ways to collaborate when it makes sense

wemeetagain pushed a commit that referenced this issue Aug 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants