Use BN for large uints #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wemeetagain
requested review from
ansermino,
GregTheGreek and
ChainSafeSystems
|
@JonathanLorimer since it doesn't look like I can make him a reviewer |
JonathanLorimer
suggested changes
Feb 8, 2019
tarasbob
reviewed
Feb 8, 2019
|
@wemeetagain just read your comment about methods postfixed with n. Ignore my comments on those methods. However, you still might want to check that comparison operations work fine without BNs. |
GregTheGreek
reviewed
Feb 8, 2019
GregTheGreek
requested changes
Feb 9, 2019
GregTheGreek
previously approved these changes
Feb 9, 2019
|
@wemeetagain we have a merge conflict! |
|
rebased off latest master |
GregTheGreek
approved these changes
Feb 10, 2019
ansermino
approved these changes
Feb 11, 2019
wemeetagain
added a commit
that referenced
this pull request
Aug 2, 2019
Change deserialize return type to any
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
re #94
resolves #89
aligns with ssz-js
Some comments:
n)log2bn method exists)num.umod(new BN(x))sections could be rewritten asnum.modn(x)since we're not expecting negative numbers in those places (I was just cautious with this first pass)