Add validator option not to submit attestation early #3944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3944 +/- ##
==========================================
+ Coverage 36.33% 36.77% +0.44%
==========================================
Files 324 325 +1
Lines 9063 9223 +160
Branches 1455 1498 +43
==========================================
+ Hits 3293 3392 +99
- Misses 5597 5640 +43
- Partials 173 191 +18 |
Performance Report✔️ no performance regression detected Full benchmark results
|
wemeetagain
reviewed
Apr 25, 2022
| @@ -61,6 +62,12 @@ export const validatorOptions: ICliCommandOptions<IValidatorCliArgs> = { | |||
| type: "string", | |||
| }, | |||
|
|
|||
| dontSubmitAttestationEarly: { | |||
There was a problem hiding this comment.
I changed the option to earlyAttestationDelayMs and use hidden:true for it
|
Checkout this PR by Nimbus, they do a happy medium, wait at least 2 seconds but still get ahead status-im/nimbus-eth2#3518 |
dadepo
reviewed
Apr 28, 2022
| // for early attestations, wait until now + 2000ms, or 1/3 of slot, whichever comes first | ||
| await sleep(Math.min(msToOneThirdSlot, this.earlyAttestationDelayMs)); | ||
| } | ||
| this.metrics?.attesterStepCallPublishAttestation.observe(this.clock.secFromSlot(slot + 1 / 3)); |
There was a problem hiding this comment.
if it is this.earlyAttestationDelayMs that comes first, won't this metric be wrong?
edit: No. Metric tracks now (whenever that might be) up till slot + 1/3
|
Looking at the Nimbus PR here, initially the wait was 250ms, then it was changed to 1000ms and now 2000ms due to the latency introduced as the network grows. Won't a more robust approach be to have beacon clients cache early attestations instead? Not sure if doing this won't conflict with other parts of the spec/implementations |
This is from the spec
so we still follow the spec. I don't think we want to introduce another cache at beacon node side unnecessarily |
dapplion
approved these changes
May 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
As monitored in hetzner-c0, there are 2 missed attestations with:
It's possible that the missed attestations were because we submit them too early, and peers ignore them (maybe due to unknown block root?). Note that lighthouse does not submit attestations early at this time
Description
Add an option to submit attestations right at 1/3 of slot so that we can test in mainnet nodes
part of #3943