increase after-block attestation delay #3518
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recently, block processing times have been going up as the network grows making early attestation riskier. Since blocks are big and attestations are small (though numerous and therefore bandwidth-intense), it seems better to wait a little bit longer after receiving a block, before we publish the attestation.
tersec
approved these changes
Mar 18, 2022
etan-status
reviewed
Mar 18, 2022
| # Regardless, because we "just" received the block, we'll impose the | ||
| # delay. | ||
|
|
||
| const afterBlockDelay = 1000 | ||
| const afterBlockDelay = millis(2000) |
There was a problem hiding this comment.
It should probably be scaled with SECONDS_PER_SLOT, or take into account the attestation_deadline. But those constants seem to be untouched on most networks.
There was a problem hiding this comment.
huh, that's a good point actually .. gnosis runs a different slot time
There was a problem hiding this comment.
the deadline would be used on those networks as an upper limit, so the impact of the change is .. limited .. but still
There was a problem hiding this comment.
But those constants seem to be untouched on most networks.
Gnosis chain changes SECONDS_PER_SLOT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently, block processing times have been going up as the network grows
making early attestation riskier. Since blocks are big and attestations
are small (though numerous and therefore bandwidth-intense), it seems
better to wait a little bit longer after receiving a block, before we
publish the attestation.