Only call regen.getBlockSlotState() if necessary #5401
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Performance Report✔️ no performance regression detected Full benchmark results
|
twoeths
force-pushed
the
tuyen/get_block_slot_state
branch
from
de5dd3b
to
7b1c83f
Compare
|
Tested in the last 5h on test mainnet node (feat2 - this branch vs unstable)
|
|
🎉 This PR is included in v1.8.0 🎉 |
nflaig
reviewed
Sep 20, 2023
| // using getHeadState() means we'll use checkpointStateCache if it's available | ||
| const headState = this.getHeadState(); | ||
| // head state is in the same epoch, or we pulled up head state already from past epoch | ||
| if (epoch <= computeEpochAtSlot(headState.slot)) { |
There was a problem hiding this comment.
@tuyennhv shouldn't this be a strict equals check? I noticed this method always returns the same state if a previous epoch is passed in
There was a problem hiding this comment.
@nflaig no this should be "<=", the function means to get head state dialing to an epoch. If provided epoch < head state epoch just return head state
also if we let it pass through the below regen.getBlockSlotState call, if provided slot < head state slot it'll throw error
There was a problem hiding this comment.
That makes sense, I was trying to figure out what would be required to get proposer duties of a finalized epoch. The right method to use in that case would be getStateBySlot I'd assume.
You also noted in #5846 is that Lodestar does not persists finalized states very frequently which would be an issue in that case. We could solve this issue if we add
--chain.archiveStateEpochFrequency 1 flag but this significantly increases storage requirements (but that might be fine for someone that really needs that data).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
validator_exitmessages at the same timeDescription
regen.getBlockSlotState()always use queue implementation so we use it with care, only call it if necessarygetHeadStateAtCurrentEpoch()andgetHeadStateAtEpoch()apis in chain so it only callsregenif necessary, using thecheckpointStateCache(used insidegetHeadState()) it'll reach the queue 1 time at most per epochclose #5400