-
-
Notifications
You must be signed in to change notification settings - Fork 446
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clear up Highlight sound settings #4194
Clear up Highlight sound settings #4194
Conversation
clang-tidy review says "All clean, LGTM! 👍" |
suggestions:
|
Things I noticed:
|
Removed.
It's hidden now.
This doesn't really fit the other settings. A user can now click on the path to open a file.
I removed the checkbox since it wasn't used.
There were actually settings for the sound-urls. But they weren't used, so I removed them. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
If you set a sound with a long file name in the "Custom Sound" column and restart the program, the "Pattern" column becomes relatively narrow (Tested with 40 characters, including file extension) If a sound with a long file name is set as "default sound", the settings window becomes wider (Tested with 80 characters, including file extension) If you try this yourself, then make sure not to test the points above at the same time |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing sounds doesn't update, it requires a restart
848d7a4
to
a9bb85f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
Turns out if you update your branch and the formatting config changes, you need to reformat.
048778d
to
b2b6560
Compare
Should be twice the width now, though this should really be changed after #3690.
Filenames are now truncated to 50 characters. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
It doesn't change anything for me, but it seems to be a general issue that isn't unique to this settings page.
It's okay. Maybe it shouldn't be limited to a certain number but to the current size of the window. So making it wider reveals more of the name. I'll let you decide what is better. |
Pull request checklist:
CHANGELOG.md
was updated, if applicableDescription
As discussed in #1540, this clears up the highlight settings for sounds:
Without custom default sound
Closes #1540.