Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear up Highlight sound settings #4194

Merged
merged 16 commits into from
Dec 3, 2022
Merged

Clear up Highlight sound settings #4194

merged 16 commits into from
Dec 3, 2022

Commits on Dec 3, 2022

  1. refactor: clear up confusing highlight settings

    @Nerixyz
    Nerixyz committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    aa67021 View commit details
    Browse the repository at this point in the history

  2. chore: add changelog entry

    @Nerixyz
    Nerixyz committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    a17fea4 View commit details
    Browse the repository at this point in the history

  3. refactor: only show cancel button if sound is set

    @Nerixyz
    Nerixyz committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    a1b9b67 View commit details
    Browse the repository at this point in the history

  4. fix: remove unused checkbox

    @Nerixyz
    Nerixyz committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    cc3ff97 View commit details
    Browse the repository at this point in the history

  5. fix: remove unused imports and #defines

    @Nerixyz
    Nerixyz committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    873b95c View commit details
    Browse the repository at this point in the history

  6. feat: linkify sound path

    @Nerixyz
    Nerixyz committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    fbe217b View commit details
    Browse the repository at this point in the history

  7. fix: remove unused file url items

    @Nerixyz
    Nerixyz committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    59590bb View commit details
    Browse the repository at this point in the history

  8. fix: missing settings in rebuildListener_

    @Nerixyz
    Nerixyz committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    b437bf9 View commit details
    Browse the repository at this point in the history

  9. fix: unused include

    @Nerixyz
    Nerixyz committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    141f0eb View commit details
    Browse the repository at this point in the history

  10. fix: remove commented out setting

    @Nerixyz
    Nerixyz committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    c1160b1 View commit details
    Browse the repository at this point in the history

  11. fix: put comment above the function

    @Nerixyz
    Nerixyz committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    b185475 View commit details
    Browse the repository at this point in the history

  12. fix: formatting 

    Turns out if you update your branch and the formatting config changes, you need to reformat.
    @Nerixyz
    Nerixyz committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    c580f94 View commit details
    Browse the repository at this point in the history

  13. fix: limit path to 50 characters

    @Nerixyz
    Nerixyz committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    05eac17 View commit details
    Browse the repository at this point in the history

  14. fix: make pattern column bigger

    @Nerixyz
    Nerixyz committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    b2b6560 View commit details
    Browse the repository at this point in the history

  15. fix sub highlight sound loading the wrong sound

    @pajlada
    pajlada committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    131001d View commit details
    Browse the repository at this point in the history

  16. Add changelog entry for the bugs fixed

    @pajlada
    pajlada committed Dec 3, 2022
    Configuration menu
    Copy the full SHA
    b81e28d View commit details
    Browse the repository at this point in the history