Populate mentions tab with message history #4475
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2547techno
force-pushed
the
c2/feat/recent-messages-mentions-tab
branch
from
a71d765
to
83c0045
Compare
|
builds failed because dependency installation timed out |
Felanbird
reviewed
Aug 4, 2023
| } | ||
| } | ||
|
|
||
| getApp()->getTwitch()->mentionsChannel->fillInMissingMessages(msgs); |
There was a problem hiding this comment.
Suggested change
| getApp()->getTwitch()->mentionsChannel->fillInMissingMessages(msgs); | |
| getApp()->twitch->mentionsChannel->fillInMissingMessages(msgs); |
Felanbird
reviewed
Aug 4, 2023
| @@ -18,6 +18,7 @@ | |||
| - Minor: 7TV badges now automatically update upon changing. (#4512) | |||
| - Minor: Stream status requests are now batched. (#4713) | |||
| - Minor: Added `/c2-theme-autoreload` command to automatically reload a custom theme. This is useful for when you're developing your own theme. (#4718) | |||
| - Minor: Populate mentions tab with messages from history. (#4475) | |||
There was a problem hiding this comment.
Suggested change
| - Minor: Populate mentions tab with messages from history. (#4475) | |
| - Minor: Mentions loaded from message history will now appear in the /mentions tab. (#4475) |
explains what the feature actually does better for users
There was a problem hiding this comment.
Maybe replace message history with historical messages. This is the term we use i think
Felanbird
approved these changes
Aug 4, 2023
|
Closing in favour of #4752 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist:
CHANGELOG.mdwas updated, if applicableDescription
An implementation of #4474
Ended up just adding to mentions tab when message history is loaded from joining a new channel rather than just on startup.
Messages preserve their chronological order in the mentions tab, so opening a channel that you have a mention in will not necessary place that message at the bottom of the split.