Highlights loaded from message history will now correctly appear in the /mentions channel #4752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ages-mentions-tab
Co-authored-by: Felanbird <[email protected]>
1 task
|
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -1121,6 +1121,21 @@ void TwitchChannel::loadRecentMessages() | |||
|
|
|||
| tc->addMessagesAtStart(messages); | |||
| tc->loadingRecentMessages_.clear(); | |||
|
|
|||
| std::vector<MessagePtr> msgs; | |||
| for (MessagePtr msg : messages) | |||
There was a problem hiding this comment.
warning: variable 'msg' of type 'chatterino::MessagePtr' (aka 'shared_ptr') can be declared 'const' [misc-const-correctness]
Suggested change
| for (MessagePtr msg : messages) | |
| for (MessagePtr const msg : messages) |
| @@ -1121,6 +1121,21 @@ | |||
|
|
|||
| tc->addMessagesAtStart(messages); | |||
| tc->loadingRecentMessages_.clear(); | |||
|
|
|||
| std::vector<MessagePtr> msgs; | |||
| for (MessagePtr msg : messages) | |||
There was a problem hiding this comment.
warning: loop variable is copied but only used as const reference; consider making it a const reference [performance-for-range-copy]
Suggested change
| for (MessagePtr msg : messages) | |
| for (const MessagePtr& msg : messages) |
Nerixyz
pushed a commit
to Nerixyz/chatterino2
that referenced
this pull request
Aug 12, 2023
…he /mentions channel (Chatterino#4752) * added messages in mentions tab if correct predicate is met * Update CHANGELOG.md * Apply Felanbird's fix Co-authored-by: Felanbird <[email protected]> --------- Co-authored-by: 2547techno <[email protected]> Co-authored-by: 2547techno <[email protected]> Co-authored-by: Mm2PL <[email protected]> Co-authored-by: Felanbird <[email protected]>
Nerixyz
pushed a commit
to Nerixyz/chatterino2
that referenced
this pull request
Aug 19, 2023
…he /mentions channel (Chatterino#4752) * added messages in mentions tab if correct predicate is met * Update CHANGELOG.md * Apply Felanbird's fix Co-authored-by: Felanbird <[email protected]> --------- Co-authored-by: 2547techno <[email protected]> Co-authored-by: 2547techno <[email protected]> Co-authored-by: Mm2PL <[email protected]> Co-authored-by: Felanbird <[email protected]>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Originally #4475