Fix Qt6 crash when dragging rows in table views #4567
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the crash described in #4563.
I have no clue why the previous code worked in the first place.
from
andto
are row-indices:chatterino2/src/common/SignalVectorModel.hpp
Lines 322 to 323 in 6338d09
QAbstractItemModel::index
takes arow
,column
, and (optional)parent
(🤓 actuallyQAbstractTableModel::index
is called, but this doesn't do any fancy things).to
is passed at the second argument - in the position of column 💫chatterino2/src/common/SignalVectorModel.hpp
Line 336 in 6338d09
to
isn't a column-index - this won't end well 🤦♀️I changed the column index to
0
which should always be a valid column index. One could also use the column index ofparent
. But this doesn't really matter since we're moving rows.Fixes #4563.