Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Qt6 crash when dragging rows in table views #4567

Merged
merged 3 commits into from
Apr 21, 2023
Merged

Fix Qt6 crash when dragging rows in table views #4567

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f2322f4
fix: always use the first column for the index
Nerixyz Apr 21, 2023
fff9b66
chore: add changelog entry
Nerixyz Apr 21, 2023
21bc45e
fix: downgrade changelog entry
Nerixyz Apr 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@
- Dev: Experimental builds with Qt 6 are now provided. (#4522, #4551, #4553, #4554, #4555, #4556)
- Dev: Removed `CHATTERINO_TEST` definitions. (#4526)
- Dev: Builds for macOS now have `macos` in their name (previously: `osx`). (#4550)
- Dev: Fixed a crash when dragging rows in table-views in builds with Qt 6. (#4567)

## 2.4.2

Expand Down
2 changes: 1 addition & 1 deletion src/common/SignalVectorModel.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,7 +333,7 @@ class SignalVectorModel : public QAbstractTableModel,

if (from != to)
{
this->moveRow(this->index(from, to), from, parent, to);
this->moveRow(this->index(from, 0), from, parent, to);
}

// We return false since we remove items ourselves.
Expand Down