revert 'not showing errors from SCA for threshold' (AST-43867) (#796)

* revert "not showing errors from SCA for threshold" * fix lint
Checkmarx · Jul 16, 2024 · df80496 · df80496
1 parent 71e3ec4
commit df80496
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/internal/commands/result.go b/internal/commands/result.go
@@ -1018,7 +1018,7 @@ func CreateScanReport(
 		return err
 	}
 	if !scanPending {
-		results, err = ReadResults(resultsWrapper, scan, params, false)
+		results, err = ReadResults(resultsWrapper, scan, params)
 		if err != nil {
 			return err
 		}
@@ -1252,7 +1252,6 @@ func ReadResults(
 	resultsWrapper wrappers.ResultsWrapper,
 	scan *wrappers.ScanResponseModel,
 	params map[string]string,
-	isThresholdCheck bool,
 ) (results *wrappers.ScanResultsCollection, err error) {
 	var resultsModel *wrappers.ScanResultsCollection
 	var errorModel *wrappers.WebError
@@ -1275,7 +1274,7 @@ func ReadResults(
 			resultsModel = ComputeRedundantSastResults(resultsModel)
 		}
 		resultsModel, err = enrichScaResults(resultsWrapper, scan, params, resultsModel)
-		if err != nil && !isThresholdCheck {
+		if err != nil {
 			return nil, err
 		}
 

diff --git a/internal/commands/scan.go b/internal/commands/scan.go
@@ -1998,7 +1998,7 @@ func getSummaryThresholdMap(resultsWrapper wrappers.ResultsWrapper, scan *wrappe
 	map[string]int,
 	error,
 ) {
-	results, err := ReadResults(resultsWrapper, scan, params, true)
+	results, err := ReadResults(resultsWrapper, scan, params)
 	if err != nil {
 		return nil, err
 	}