Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert 'not showing errors from SCA for threshold' (AST-43867) #796

Merged
merged 2 commits into from
Jul 16, 2024

Conversation

elchananarb
Copy link
Contributor

Description

In the past, we suppressed the exception and did not return an error if there was a failure. Now, we are reverting to the previous state and ensuring that an error is returned if there is a failure because the SAP error could not be reproduced. This decision was confirmed after checking with Michael Kubiaczyk, who used a SAP account for verification.

References

https://checkmarx.atlassian.net/browse/AST-43867
https://checkmarx.atlassian.net/browse/AST-42820

@pedrompflopes pedrompflopes requested a review from a team July 14, 2024 07:16
Copy link

github-actions bot commented Jul 14, 2024

Logo
Checkmarx One – Scan Summary & Details3bfc52e4-fe85-45ac-9f4f-716e922216ed

Policy Management Violations

Policy Name Rule(s) Break Build
[SAST-ML0] Not allowed NEW Sast vulnerabilities true

No New Or Fixed Issues Found

@elchananarb elchananarb changed the title revert "not showing errors from SCA for threshold" revert 'not showing errors from SCA for threshold' (AST-43867) Jul 14, 2024
@OrShamirCM OrShamirCM merged commit df80496 into main Jul 16, 2024
9 checks passed
@OrShamirCM OrShamirCM deleted the revert/elchanan/sca-failure-threshold branch July 16, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants