-
Notifications
You must be signed in to change notification settings - Fork 307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(query): fixed issue containers_running_as_root #3412 #3422
fix(query): fixed issue containers_running_as_root #3412 #3422
Conversation
Scan submitted to Checkmarx |
Hi @mukeshpilaniya , first welcome to KICS, we're happy to get a PR from you 👍 A bit on the OCD side, but can you fix the typo in the PR/commit? container_ruuiing_as_root -> containers_running_as_root and to close the issue it refers (see this ). Thanks (: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general, I think the query changes looks good, I would like just to ask to you to add positive and negative samples covering your new edge case.
If you need some help with this, don't hesitate to ask by @ us at this thread, using gitter or [email protected]
Scan not submitted to Checkmarx due to existing Active scan for the same project. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you @mukeshpilaniya
We just need to check why integration tests are failing
This PR should fix the integration tests issue #3430 |
Hi @mukeshpilaniya, now that #3430 is merged can you please update your branch to the master so we can run the PR checks again? |
@rogeriopeixotocx, I updated my branch to the master branch. now you can run the Integration test again. |
Hi @mukeshpilaniya, I think you forgot to pull the latest changes in the master branch, can you pull and then merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@mukeshpilaniya thank you for your contribution |
Fixes #3412 Containers_running_as_root query failed to evaluate
Description
Added one more corner case and fixed already existing issue #3412