fix(query): fixed issue containers_running_as_root #3412

[mukeshpilaniya]

Fixes #3412 Containers_running_as_root query failed to evaluate

Description

Added one more corner case and fixed already existing issue #3412

#if pod runAsNonRoot==true and container runAsNonRoot==true (container not runs as root)
#if pod runAsNonRoot==true and container runAsNonRoot==false 
							#if container runAsUser>0 (container not runs as root)
							#if container runAsUser<=0 (container runs as root) //new added corner case

[kicsbot]

Scan submitted to Checkmarx

[kicsbot]

Checkmarx SAST - Scan Summary & Details

Cx-SAST Summary

Total of 0 vulnerabilities
 0 High
 0 Medium
 0 Low
 0 Info

Violation Summary

No policy violation found

[kaplanlior]

Hi @mukeshpilaniya , first welcome to KICS, we're happy to get a PR from you 👍

A bit on the OCD side, but can you fix the typo in the PR/commit? container_ruuiing_as_root -> containers_running_as_root and to close the issue it refers (see this ).

Thanks (:

[felipe-avelar]

In general, I think the query changes looks good, I would like just to ask to you to add positive and negative samples covering your new edge case.
If you need some help with this, don't hesitate to ask by @ us at this thread, using gitter or [email protected]

[kicsbot]

Scan not submitted to Checkmarx due to existing Active scan for the same project.

[rogeriopeixotocx]

LGTM, thank you @mukeshpilaniya

We just need to check why integration tests are failing

outdated

[rogeriopeixotocx]

This PR should fix the integration tests issue #3430

[rogeriopeixotocx]

Hi @mukeshpilaniya, now that #3430 is merged can you please update your branch to the master so we can run the PR checks again?

[mukeshpilaniya]

Hi @mukeshpilaniya, now that #3430 is merged can you please update your branch to the master so we can run the PR checks again?

@rogeriopeixotocx, I updated my branch to the master branch. now you can run the Integration test again.

[joaoReigota1]

Hi @mukeshpilaniya, now that #3430 is merged can you please update your branch to the master so we can run the PR checks again?

@rogeriopeixotocx, I updated my branch to the master branch. now you can run the Integration test again.

Hi @mukeshpilaniya, I think you forgot to pull the latest changes in the master branch, can you pull and then merge?

[rogeriopeixotocx]

LGTM

[rogeriopeixotocx]

@mukeshpilaniya thank you for your contribution