refactor(query): containers_run_with_low_uid rewrite #3430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Scan submitted to Checkmarx |
|
Cx-SAST SummaryTotal of 0 vulnerabilities Violation SummaryNo policy violation found |
joaoReigota1
previously requested changes
May 25, 2021
| "documentId": id, | ||
| "searchKey": sprintf("metadata.name={{%s}}.%sspec.securityContext.runAsUser", [metadata.name, path]), | ||
| "documentId": doc.id, | ||
| "searchKey": sprintf("%s.securityContext.runAsUser=%d", [common_lib.concat_path(path), securityContext.runAsUser]), |
There was a problem hiding this comment.
Since in line 11 we use to_number, I assume security context can be something other than an integer, maybe use to_number in the search key as well so it doesn't conflict with %d
There was a problem hiding this comment.
Suggested change
| "searchKey": sprintf("%s.securityContext.runAsUser=%d", [common_lib.concat_path(path), securityContext.runAsUser]), | |
| "searchKey": sprintf("%s.securityContext.runAsUser=%d", [common_lib.concat_path(path), to_number(securityContext.runAsUser)]), |
There was a problem hiding this comment.
I don't think we need to add to_number here, since it will only execute this line if runAsUser is a number, otherwise, it will fail on the first to_number, no?
There was a problem hiding this comment.
I think @felipe-avelar is right @joaoReigota1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I submit this contribution under the Apache-2.0 license.