Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update(query): Updated Unrestricted SQL Server Access query #3463

Merged

Conversation

joaoReigota1
Copy link
Collaborator

Signed-off-by: João Reigota [email protected]

Closes #3444

Proposed Changes

  • Updated Unrestricted SQL Server Access query for Terraform and Ansible

The Azure feature Allow access to Azure services can be enabled by setting start_ip_address and end_ip_address to 0.0.0.0.
https://registry.terraform.io/providers/hashicorp/azurerm/latest/docs/resources/sql_firewall_rule#end_ip_address

I submit this contribution under the Apache-2.0 license.

@joaoReigota1 joaoReigota1 added query New query feature terraform Terraform query ansible Ansible query labels May 27, 2021
@joaoReigota1 joaoReigota1 added this to the Query Accuracy milestone May 27, 2021
@joaoReigota1 joaoReigota1 requested a review from a team May 27, 2021 17:23
@joaoReigota1 joaoReigota1 self-assigned this May 27, 2021
@kicsbot
Copy link
Contributor

kicsbot commented May 27, 2021

Scan submitted to Checkmarx

@kicsbot
Copy link
Contributor

kicsbot commented May 27, 2021

Logo
Checkmarx SAST - Scan Summary & Details

Cx-SAST Summary

Total of 0 vulnerabilities
High 0 High
Medium 0 Medium
Low 0 Low
Info 0 Info

Violation Summary

No policy violation found

Copy link
Contributor

@rogeriopeixotocx rogeriopeixotocx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rogeriopeixotocx rogeriopeixotocx merged commit 34b710e into master May 28, 2021
@rogeriopeixotocx rogeriopeixotocx deleted the feature/update_unrestricted_sql_server_access branch May 28, 2021 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ansible Ansible query query New query feature terraform Terraform query
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FP in 'Unrestricted SQL Server Access' query for Terraform
3 participants