Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update(query): Updated Unrestricted SQL Server Access query #3463

Merged
merged 1 commit into from
May 28, 2021
Merged

update(query): Updated Unrestricted SQL Server Access query #3463

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 0 additions & 17 deletions assets/queries/ansible/azure/unrestricted_sql_server_acess/query.rego
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,23 +5,6 @@ import data.generic.common as commonLib

modules := {"azure.azcollection.azure_rm_sqlfirewallrule", "azure_rm_sqlfirewallrule"}

CxPolicy[result] {
task := ansLib.tasks[id][t]
rule := task[modules[m]]
ansLib.checkState(rule)

rule.start_ip_address == "0.0.0.0"
rule.end_ip_address == "0.0.0.0"

result := {
"documentId": id,
"searchKey": sprintf("name={{%s}}.{{%s}}", [task.name, modules[m]]),
"issueType": "IncorrectValue",
"keyExpectedValue": "azure_rm_sqlfirewallrule.start_ip_address is different from '0.0.0.0' and azure_rm_sqlfirewallrule.end_ip_address is different from '0.0.0.0'",
"keyActualValue": "azure_rm_sqlfirewallrule.start_ip_address is '0.0.0.0' and azure_rm_sqlfirewallrule.end_ip_address is '0.0.0.0'",
}
}

CxPolicy[result] {
task := ansLib.tasks[id][t]
rule := task[modules[m]]
Expand Down
2 changes: 1 addition & 1 deletion assets/queries/ansible/azure/unrestricted_sql_server_acess/test/positive.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
server_name: firewallrulecrudtest-6285
name: firewallrulecrudtest-5370
start_ip_address: 0.0.0.0
end_ip_address: 0.0.0.0
end_ip_address: 172.28.11.138
- name: Create (or update) Firewall Rule2
azure_rm_sqlfirewallrule:
resource_group: myResourceGroup2
Expand Down
14 changes: 0 additions & 14 deletions assets/queries/terraform/azure/unrestricted_sql_server_acess/query.rego
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,20 +2,6 @@ package Cx

import data.generic.common as lib

CxPolicy[result] {
resource := input.document[i].resource.azurerm_sql_firewall_rule[name]
resource.start_ip_address == "0.0.0.0"
resource.end_ip_address == "0.0.0.0"

result := {
"documentId": input.document[i].id,
"searchKey": sprintf("azurerm_sql_firewall_rule[%s].start_ip_address", [name]),
"issueType": "IncorrectValue",
"keyExpectedValue": sprintf("'azurerm_sql_firewall_rule[%s].start_ip_address' is different from '0.0.0.0'", [name]),
"keyActualValue": sprintf("'azurerm_sql_firewall_rule[%s].start_ip_address' is equal to '0.0.0.0'", [name]),
}
}

CxPolicy[result] {
resource := input.document[i].resource.azurerm_sql_firewall_rule[name]
startIP_value := lib.calc_IP_value(resource.start_ip_address)
Expand Down
2 changes: 1 addition & 1 deletion assets/queries/terraform/azure/unrestricted_sql_server_acess/test/positive.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ resource "azurerm_sql_firewall_rule" "positive3" {
resource_group_name = azurerm_resource_group.example.name
server_name = azurerm_sql_server.example.name
start_ip_address = "0.0.0.0"
end_ip_address = "0.0.0.0"
end_ip_address = "10.0.27.62"
}

resource "azurerm_sql_firewall_rule" "positive4" {
Expand Down