Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build action failed in the cherryusb_esp32, but succeed in the source repo esp_cherryusb #4

Closed
leeebo opened this issue Sep 5, 2023 · 0 comments · Fixed by #5
Closed

Build action failed in the cherryusb_esp32, but succeed in the source repo esp_cherryusb #4

leeebo opened this issue Sep 5, 2023 · 0 comments · Fixed by #5

Comments

@leeebo
Copy link

leeebo commented Sep 5, 2023

@sakumisu The build action failed in the cherryusb_esp32, but succeed in the source repo esp_cherryusb, due to:

  1. We have different repo name (The build process depends on it)
  2. The cherryusb_esp32 has no token to upload to esp registry

I will fix it soon in next PR

Originally posted by @leeebo in #3 (comment)
@leeebo leeebo changed the title Build action failed in the [cherryusb_esp32](https://github.com/CherryUSB/cherryusb_esp32), but succeed in the source repo [esp_cherryusb](https://github.com/leeebo/esp_cherryusb/tree/master) Build action failed in the cherryusb_esp32, but succeed in the source repo esp_cherryusb Sep 5, 2023
leeebo added a commit to leeebo/cherryusb_esp32 that referenced this issue Sep 6, 2023
@leeebo
Rename to cherryusb_esp32 to keep consistency with upstream
5311fa5 
fix CherryUSB#4
@leeebo leeebo mentioned this issue Sep 6, 2023
Merged
sakumisu pushed a commit that referenced this issue Sep 6, 2023
@leeebo @sakumisu
Rename to cherryusb_esp32 to keep consistency with upstream
5789add 
fix #4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rename to cherryusb_esp32 to keep consistency with upstream leeebo/cherryusb_esp32
1 participant
@leeebo