Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: using esp component manager #3

Merged
merged 2 commits into from
Sep 5, 2023
Merged

Refactor: using esp component manager #3

merged 2 commits into from
Sep 5, 2023

Conversation

leeebo
Copy link

@leeebo leeebo commented Sep 5, 2023

  1. Refactor folder structure (prepare to add more examples in future)
  2. Remove submodule, using esp component manager instead
  3. Add README and License
  4. Publish the component and examples to the ESP Registry
  5. Add Github Build Actions to check the build status

@sakumisu
Copy link
Contributor

sakumisu commented Sep 5, 2023

Thanks for so detailed.

@sakumisu sakumisu merged commit 190096d into CherryUSB:master Sep 5, 2023
@leeebo
Copy link
Author

leeebo commented Sep 5, 2023

@sakumisu The build action failed in the cherryusb_esp32, but succeed in the source repo esp_cherryusb, due to:

  1. We have different repo name (The build process depends on it)
  2. The cherryusb_esp32 has no token to upload to esp registry

I will fix it soon in next PR

@leeebo leeebo mentioned this pull request Sep 5, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leeebo @sakumisu